Calculation of selling price

Bug report

Moderator: systemmods

Post Reply
team fl
Posts: 5020
Joined: Tue Mar 02, 2010 10:43 am
Contact:

Calculation of selling price

Post by team fl » Tue Nov 21, 2023 12:53 pm

Bergwerk opened a thread about the selling price of his riders in the German part of the forum: viewtopic.php?f=42&p=118952#p118952

Usually I would have thought that it's due to him not understanding the basics, but then I had a look a my own riders. And I found this for Cherif Cissé, a rider I bought as youth rider or 21 yo riders from the transfermarket before the 5th of a month, hence not bought with a reduced prize:
Value 1.628.736 $
Reduced Purchase 1.201.866 $
Sales Tax 28.42 %
Sales Penalty 0 % (78 days in team)
Sales Price 860.304 $
Same shows for Aron Abreha (reduced purchase) but f.e. not for Tesfaye Tsegaye. Alle these riders have been bougth for 95%+ of their initial market prize.

So, do I not understand the basics or is this something that should not be the case?
I didn't mean to say it. But I meant what I said.

Hansa
Posts: 954
Joined: Wed May 19, 2010 8:27 pm
Contact:

Re: Calculation of selling price

Post by Hansa » Tue Nov 21, 2023 1:32 pm

team fl wrote:
Tue Nov 21, 2023 12:53 pm
Bergwerk opened a thread about the selling price of his riders in the German part of the forum: viewtopic.php?f=42&p=118952#p118952

Usually I would have thought that it's due to him not understanding the basics, but then I had a look a my own riders. And I found this for Cherif Cissé, a rider I bought as youth rider or 21 yo riders from the transfermarket before the 5th of a month, hence not bought with a reduced prize:
Value 1.628.736 $
Reduced Purchase 1.201.866 $
Sales Tax 28.42 %
Sales Penalty 0 % (78 days in team)
Sales Price 860.304 $
Same shows for Aron Abreha (reduced purchase) but f.e. not for Tesfaye Tsegaye. Alle these riders have been bougth for 95%+ of their initial market prize.

So, do I not understand the basics or is this something that should not be the case?

Chérif Cissé (Team FL)
Status Active (reduced purchase)
Transfers
Date↓ Type Team Price
2023-09-04 Purchase Team FL $1,201,866
2023-09-01 Sale VC Team Multi $714,647
2023-09-01 Purchase VC Team Multi $1,300,000

Sales history of Cisse so it looks like he was purchased at a reduced price.

i cant check in detail how much reduced, in my opinion its still weird to calculate that on his reduced buying price since is Value changed that much.

would make more sense if purchased at 90% Value you get a 10% reduction on his current value. espacially interesting for young riders that have a big increase in value


for aron it doesnt show reduced purchase for me

Aron Abreha (Team FL)
Status Active

so if for Aron you have also the reduced purchase shown i guess thats a bug.
Hansa

est. 03.08.2009

team fl
Posts: 5020
Joined: Tue Mar 02, 2010 10:43 am
Contact:

Re: Calculation of selling price

Post by team fl » Tue Nov 21, 2023 2:29 pm

I bought Cissé as 21yo name geben rider on the normal transfermarket before the 5th of the month for 95%+ of his initial market prize. maybe he was bought and sold before, but he wasn't bought under 95%. In my book, that's not a "reduced prize rider" (verbilligter Fahrer) with special selling rules, or is it? And you couldn't even see the transfer history back then...

Anyway, the problem occurs for many riders, not only Cissé. It seems it happens to (21yo) riders bought on the normal transfer market. At least in my team.

So then the question is: is buying a 21 yo rider on the normal transfer market between 95 and 100% of his initial market prize a reduced purchased rider which will always have the initial prize as selling basis? There is also nothing in the manual under "Transfermarket" about "reduced purchased" rules.
I didn't mean to say it. But I meant what I said.

Hansa
Posts: 954
Joined: Wed May 19, 2010 8:27 pm
Contact:

Re: Calculation of selling price

Post by Hansa » Tue Nov 21, 2023 2:46 pm

team fl wrote:
Tue Nov 21, 2023 2:29 pm

So then the question is: is buying a 21 yo rider on the normal transfer market between 95 and 100% of his initial market prize a reduced purchased rider which will always have the initial prize as selling basis? There is also nothing in the manual under "Transfermarket" about "reduced purchased" rules.
it shouldnt be, on the normal market only riders below 90% should count as reduced riders.
Hansa

est. 03.08.2009

team fl
Posts: 5020
Joined: Tue Mar 02, 2010 10:43 am
Contact:

Re: Calculation of selling price

Post by team fl » Tue Nov 21, 2023 2:47 pm

Hansa wrote:
Tue Nov 21, 2023 2:46 pm
team fl wrote:
Tue Nov 21, 2023 2:29 pm

So then the question is: is buying a 21 yo rider on the normal transfer market between 95 and 100% of his initial market prize a reduced purchased rider which will always have the initial prize as selling basis? There is also nothing in the manual under "Transfermarket" about "reduced purchased" rules.
it shouldnt be, on the normal market only riders below 90% should count as reduced riders.
Exactly. Hence this thread :)
I didn't mean to say it. But I meant what I said.

Hansa
Posts: 954
Joined: Wed May 19, 2010 8:27 pm
Contact:

Re: Calculation of selling price

Post by Hansa » Tue Nov 21, 2023 2:49 pm

the different between cisse and the others is that cisse is the only one that is shown as reduced purchase on the rider profile the other riders are not.

so thats 2 different bugs then.

alk hast to check them both then
Hansa

est. 03.08.2009

team fl
Posts: 5020
Joined: Tue Mar 02, 2010 10:43 am
Contact:

Re: Calculation of selling price

Post by team fl » Tue Nov 21, 2023 2:52 pm

Haven't even realised that Cissé has that label. Anyway, Also Abreha's and Kgotsile's seeling price is calculated with a "reduced purchase" basis. And again, all three riders have been bought as name geben riders with 95%+ of their initial market prize.

Any my guess is, that he has to check a lot of riders with the same bug/feature, let alone the berwerk riders that brought this thread into existance in the first place.
I didn't mean to say it. But I meant what I said.

Alkworld
Posts: 1139
Joined: Sat Feb 27, 2010 8:40 pm
Contact:

Re: Calculation of selling price

Post by Alkworld » Tue Nov 21, 2023 10:17 pm

What I found until now (from what you wrote and looking at the code):
- the issue is only for riders from the regular market, not for riders from youth market
- the database keeps the reduced purchase price separately, but also for not reduced price riders (> 90%)
- with old riders nobody notices, as they decrease anyway in price
- after the fix in the code in September I think I added the reducedPrice flag in the database via script, but possibly hit some young riders as well, where the value grew a lot meanwhile. Those should be the ones 24+ (Cisse doesn't fit here)

Conclusion for now is to update the affected riders (not easy to find the right ones, one attempt below), and check the code to not set riders reduced price, if they weren't actually reduced (i.e. below 90%)

I found the following riders (many names you mentioned are in there, let me know if you miss some):
[
{"name":"Anas Muwahidi","team":"Wydad Casablanca","age":"32","preis":"1579336","verkaufpreis":"1400434"},
{"name":"Aron Abreha","team":"Team FL","age":"24","preis":"2527560","verkaufpreis":"1859831"},
{"name":"Bachir Baccour","team":"Pokemonogatari","age":"25","preis":"1973113","verkaufpreis":"1582505"},
{"name":"Benjamin Kabel","team":"OMG Berlin","age":"25","preis":"3699893","verkaufpreis":"2536829"},
{"name":"Chantal Hagel","team":"Schappy","age":"22","preis":"3155299","verkaufpreis":"2798000"},
{"name":"Claas Petersen","team":"FSG Sattelpuper","age":"22","preis":"1710268","verkaufpreis":"1501089"},
{"name":"Danny Caldwell","team":"Lindor Team","age":"29","preis":"1702683","verkaufpreis":"1524949"},
{"name":"Fabian Hoffmann","team":"High Voltage","age":"23","preis":"2009514","verkaufpreis":"1799000"},
{"name":"Gary Fisher","team":"FB Radsport Team","age":"24","preis":"1949693","verkaufpreis":"1488315"},
{"name":"Gethin Gold","team":"bergwerk","age":"29","preis":"2659216","verkaufpreis":"2085925"},
{"name":"Gonzalo Mabchado","team":"Cultural Salamanca","age":"22","preis":"2617430","verkaufpreis":"2256789"},
{"name":"Guido Maneiro","team":"Atletico Lula","age":"25","preis":"1915828","verkaufpreis":"1585685"},
{"name":"Jaapo Sarvilinna","team":"Liberty Sarténe","age":"31","preis":"2051575","verkaufpreis":"1713750"},
{"name":"Jan Baas","team":"Team-Phoenix","age":"25","preis":"1687052","verkaufpreis":"1337034"},
{"name":"John Hill","team":"waerl","age":"22","preis":"1210100","verkaufpreis":"1049000"},
{"name":"JuanMora Brenes","team":"free team","age":"25","preis":"1937452","verkaufpreis":"1446537"},
{"name":"Julius Müller","team":"Christie","age":"24","preis":"1925170","verkaufpreis":"1520659"},
{"name":"Kevin Behrens","team":"rsv lünen","age":"23","preis":"2027971","verkaufpreis":"1773938"},
{"name":"Kurt Wenig","team":"Ansach","age":"22","preis":"1367132","verkaufpreis":"1140704"},
{"name":"Lucas Melano","team":"Atletico Lula","age":"25","preis":"1383396","verkaufpreis":"1212197"},
{"name":"Lukas Eberharter","team":"High Voltage","age":"22","preis":"4032849","verkaufpreis":"3436480"},
{"name":"Manfred Köstner","team":"Jockelsteam","age":"22","preis":"1810843","verkaufpreis":"1594202"},
{"name":"Marc Contador","team":"High Voltage","age":"22","preis":"3753926","verkaufpreis":"3217491"},
{"name":"Markus Mayer","team":"Team Viromet","age":"22","preis":"1506137","verkaufpreis":"1200000"},
{"name":"Noah Rey","team":"Hansa","age":"22","preis":"2295001","verkaufpreis":"1948869"},
{"name":"Noam Amar","team":"Schartner Bombe","age":"22","preis":"2077449","verkaufpreis":"1837531"},
{"name":"Nuno Guedes","team":"Ibiza ushuaia","age":"22","preis":"1662447","verkaufpreis":"1320000"},
{"name":"ottavio crepaldi","team":"enzano veloclub","age":"24","preis":"1886289","verkaufpreis":"1600159"},
{"name":"Peter Klöppel","team":"Bahrain-Merida","age":"28","preis":"1702175","verkaufpreis":"1373507"},
{"name":"Przemyslaw Pszczolarski","team":"Team FL","age":"32","preis":"2512451","verkaufpreis":"2000641"},
{"name":"Ragnar Mannsverk","team":"Claw - CVIII","age":"22","preis":"1982390","verkaufpreis":"1653001"},
{"name":"Rene Binder","team":"Bugatti","age":"23","preis":"4087744","verkaufpreis":"3070307"},
{"name":"Reuben Kemp","team":"Tukhtahuaev","age":"22","preis":"1792266","verkaufpreis":"1575000"},
{"name":"Rikard Juul","team":"Medical Service","age":"28","preis":"2638589","verkaufpreis":"1820110"},
{"name":"Roberto Cipollini","team":"High Voltage","age":"22","preis":"2476953","verkaufpreis":"2134659"},
{"name":"Sebastian Moyano","team":"Atletico Lula","age":"26","preis":"1858600","verkaufpreis":"1396368"},
{"name":"Sun Kim","team":"AGF (Asso du Ghetto FR)","age":"23","preis":"1361003","verkaufpreis":"1107105"},
{"name":"Temptation Chimwemwe","team":"Dreizehn","age":"22","preis":"1752287","verkaufpreis":"1535132"},
{"name":"Zvi Levy","team":"Schartner Bombe","age":"23","preis":"1611076","verkaufpreis":"1354814"}
]

Edit: updated the list to include also riders until 32, but also filtered for exactly one transfer.

ATB - Racing
Posts: 246
Joined: Fri May 04, 2012 11:57 am
Contact:

Re: Calculation of selling price

Post by ATB - Racing » Wed Nov 22, 2023 2:24 am

Medical (Servicio Médico) opened a thread a while ago: (Rikard Juul) well he is on your list above.

viewtopic.php?f=5&t=9625

Alkworld
Posts: 1139
Joined: Sat Feb 27, 2010 8:40 pm
Contact:

Re: Calculation of selling price

Post by Alkworld » Wed Nov 22, 2023 9:13 pm

I corrected the data now directly in the database, so please check, if the sales price is correct for you now. The bug when buying 21yo riders later show as reduced riders "should" be gone as well, but keep an eye on it.

team fl
Posts: 5020
Joined: Tue Mar 02, 2010 10:43 am
Contact:

Re: Calculation of selling price

Post by team fl » Thu Nov 23, 2023 12:40 pm

Abreha looks fine, Kgositsile and Cissé still have the "reduced purchase" entry.
I didn't mean to say it. But I meant what I said.

CircleCycle
Posts: 468
Joined: Tue Mar 05, 2013 9:45 am
Contact:

Re: Calculation of selling price

Post by CircleCycle » Mon Apr 22, 2024 1:04 pm

can you please check my rider Sullivan.
he is shown as reduced purchase
thx

Post Reply

Who is online

Users browsing this forum: No registered users and 17 guests